Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Piano based on samples #221

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Piano based on samples #221

merged 1 commit into from
Dec 5, 2024

Conversation

michalsek
Copy link
Member

@michalsek michalsek commented Dec 5, 2024 •
edited
Loading

Closes #223

Introduced changes

  • Replaces oscillators in piano example with AudioBufferSurceNodes with piano sample files

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code

@michalsek michalsek self-assigned this Dec 5, 2024
@michalsek michalsek merged commit bdad8eb into main Dec 5, 2024
11 checks passed
@maciejmakowski2003 maciejmakowski2003 deleted the feat/examples/piano branch December 10, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciejmakowski2003 maciejmakowski2003 maciejmakowski2003 approved these changes

Assignees

@michalsek michalsek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Example] Piano keyboard using samples
2 participants
@michalsek @maciejmakowski2003