Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#201] [Core] AudioBus - support for multiple node connections and mixed amount of channels #206

Merged
merged 36 commits into from
Nov 26, 2024

Conversation

michalsek
Copy link
Member

@michalsek michalsek commented Nov 15, 2024

Closes #201
Closes #172

Introduced changes

  • Multi-node support through up-down mixable AudioBus implementation and internal node buses.
  • Fix issues with memory allocation and de-allocation by:
    • restricting internal graph connection changes to be done only when holding a graph mutext, as well as only at the begining of the render quantum.
    • Creating AudioNodeManager which keeps references to source nodes as well as nodes that has pending connection change (wait for connect or for disconnect)
  • Fixes some minor issues or typos
  • Improves AudioBufferSourceNode performance by taking advantage of memory operation as much as possible

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code

This comment has been minimized.

This comment has been minimized.

@michalsek michalsek changed the title [#201] [Core] AudioBus - support for multiple node connections and mixed amout of channels [#201] [Core] AudioBus - support for multiple node connections and mixed amount of channels Nov 21, 2024
@michalsek michalsek self-assigned this Nov 26, 2024
@michalsek michalsek marked this pull request as ready for review November 26, 2024 13:58
@maciejmakowski2003
Copy link
Collaborator

Amazing work!!!🔥

@michalsek michalsek merged commit 3c924bf into main Nov 26, 2024
11 checks passed
@michalsek michalsek deleted the feat/core/rework-buffers branch November 26, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audio Processing - support multi-node connections Improve audio processing performence
2 participants