Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/periodic wave #205

Merged
merged 36 commits into from
Nov 25, 2024
Merged

Feat/periodic wave #205

merged 36 commits into from
Nov 25, 2024

Conversation

maciejmakowski2003
Copy link
Collaborator

@maciejmakowski2003 maciejmakowski2003 commented Nov 14, 2024

Closes #165
Closes #208

Introduced changes

  • Implemented PeriodicWave
  • Implemented setPeriodicWave method
  • Implemented createPeriodicWave method
  • Introduced PeriodicWave into generating wave samples process in OscillatorNode
  • Provided explaining comments
  • Updated TS interfaces
  • Refactored enum names

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code

@maciejmakowski2003 maciejmakowski2003 self-assigned this Nov 14, 2024

This comment has been minimized.

This comment has been minimized.

@maciejmakowski2003 maciejmakowski2003 marked this pull request as draft November 15, 2024 11:39
@maciejmakowski2003 maciejmakowski2003 marked this pull request as ready for review November 15, 2024 11:40
@michalsek michalsek self-requested a review November 25, 2024 09:44
@maciejmakowski2003 maciejmakowski2003 merged commit c7acb44 into main Nov 25, 2024
11 checks passed
@maciejmakowski2003 maciejmakowski2003 deleted the feat/periodic-wave branch November 25, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add FFT implementation on Android Implement PeriodicWave
2 participants