Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A bit more appealing drum machine example #185

Merged
merged 4 commits into from
Oct 29, 2024
Merged

A bit more appealing drum machine example #185

merged 4 commits into from
Oct 29, 2024

Conversation

michalsek
Copy link
Member

@michalsek michalsek commented Oct 27, 2024 •
edited
Loading

Will do the PR description on monday :)

Closes #

Introduced changes

Examples:

  • Improves Slider performance (android) by updating the state value only at the end of the gesture + built-in label
  • Adds select component
  • Adds swm icon pack
  • Adds spport of skia rendering
  • Design overhaul
  • Drum-machine example overhaul

API:

  • do not call processAudio on nullptrs :)

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code

michalsek
michalsek commented Oct 28, 2024
View reviewed changes
apps/common-app/src/App.tsx Outdated Show resolved Hide resolved
apps/common-app/src/components/Select.tsx Show resolved Hide resolved
apps/common-app/src/components/Select.tsx Outdated Show resolved Hide resolved
apps/common-app/src/components/Select.tsx Outdated Show resolved Hide resolved
apps/common-app/src/components/Select.tsx Outdated Show resolved Hide resolved
apps/common-app/src/examples/DrumMachine/Grid.tsx Outdated Show resolved Hide resolved
apps/common-app/src/examples/DrumMachine/Grid.tsx Outdated Show resolved Hide resolved
apps/common-app/src/examples/DrumMachine/useGestures.ts Outdated Show resolved Hide resolved
apps/common-app/src/examples/DrumMachine/usePlayer.tsx Show resolved Hide resolved
apps/common-app/src/examples/DrumMachine/usePlayer.tsx Show resolved Hide resolved
@michalsek michalsek self-assigned this Oct 28, 2024
@michalsek michalsek marked this pull request as ready for review October 28, 2024 15:12
maciejmakowski2003
maciejmakowski2003 reviewed Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@maciejmakowski2003 maciejmakowski2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall really great job. It looks outstanding!

@michalsek michalsek merged commit 39dcf3d into main Oct 29, 2024
2 checks passed
@michalsek michalsek deleted the feat/drum-machine-reanimated branch October 29, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciejmakowski2003 maciejmakowski2003 maciejmakowski2003 approved these changes

Assignees

@michalsek michalsek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalsek @maciejmakowski2003