Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/base audio context #179

Merged
merged 6 commits into from
Oct 31, 2024
Merged

Refactor/base audio context #179

merged 6 commits into from
Oct 31, 2024

Conversation

maciejmakowski2003
Copy link
Collaborator

@maciejmakowski2003 maciejmakowski2003 commented Oct 24, 2024 •
edited
Loading

Closes #157

Introduced changes

  • Implemented BaseAudioContext classes
  • Introduced inheritance between BaseAudioContext and AudioContext
  • Added [[nodiscard]] attribute

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code

@maciejmakowski2003 maciejmakowski2003 self-assigned this Oct 24, 2024
@maciejmakowski2003 maciejmakowski2003 merged commit 385da39 into main Oct 31, 2024
2 checks passed
@maciejmakowski2003 maciejmakowski2003 deleted the refactor/base-audio-context branch October 31, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsek michalsek michalsek approved these changes

Assignees

@maciejmakowski2003 maciejmakowski2003

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement BaseAudioContext interface
2 participants
@maciejmakowski2003 @michalsek