fix: moved creating audio context host object method to host object

software-mansion-labs · Jul 19, 2024 · fc190c8 · fc190c8
1 parent ea2de9e
commit fc190c8
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 14 deletions.
diff --git a/android/src/main/cpp/AudioContext.cpp b/android/src/main/cpp/AudioContext.cpp
@@ -11,7 +11,7 @@ namespace audiocontext
   {
     auto audioContextWrapper = std::make_shared<AudioContextWrapper>(std::shared_ptr<AudioContext>(this));
     auto runtime = reinterpret_cast<jsi::Runtime *>(jsContext);
-    auto hostObject = std::make_shared<AudioContextHostObject>(audioContextWrapper);
+    auto hostObject = AudioContextHostObject::createFromWrapper(audioContextWrapper);
 
     auto object = jsi::Object::createFromHostObject(*runtime, hostObject);
     runtime->global().setProperty(*runtime, "__AudioContextProxy", std::move(object));

diff --git a/cpp/AudioContext/AudioContextHostObject.h b/cpp/AudioContext/AudioContextHostObject.h
@@ -1,26 +1,32 @@
 #pragma once
 
+#include <jsi/jsi.h>
 #include "AudioContextWrapper.h"
 
 namespace audiocontext
 {
-  using namespace facebook;
+    using namespace facebook;
 
-  class AudioContextWrapper;
+    class AudioContextWrapper;
 
-  class AudioContextHostObject : public jsi::HostObject
-  {
-  private:
-    std::shared_ptr<AudioContextWrapper> wrapper_;
+    class AudioContextHostObject : public jsi::HostObject
+    {
+    private:
+        std::shared_ptr<AudioContextWrapper> wrapper_;
 
-  public:
-    explicit AudioContextHostObject(std::shared_ptr<AudioContextWrapper> wrapper) : wrapper_(wrapper) {}
+    public:
+        explicit AudioContextHostObject(std::shared_ptr<AudioContextWrapper> wrapper) : wrapper_(wrapper) {}
 
-    jsi::Value get(jsi::Runtime &runtime, const jsi::PropNameID &name) override;
-    void set(jsi::Runtime &runtime, const jsi::PropNameID &name, const jsi::Value &value) override;
-    std::vector<jsi::PropNameID> getPropertyNames(jsi::Runtime &rt) override;
+        static std::shared_ptr<AudioContextHostObject> createFromWrapper(std::shared_ptr<AudioContextWrapper> wrapper) {
+            return std::make_shared<AudioContextHostObject>(wrapper);
+        }
+
+        jsi::Value get(jsi::Runtime &runtime, const jsi::PropNameID &name) override;
+        void set(jsi::Runtime &runtime, const jsi::PropNameID &name, const jsi::Value &value) override;
+        std::vector<jsi::PropNameID> getPropertyNames(jsi::Runtime &rt) override;
+
+        jsi::Value createOscillator(jsi::Runtime& runtime, const jsi::PropNameID& propNameId);
+        jsi::Value getDestination(jsi::Runtime& runtime, const jsi::PropNameID& propNameId);
 
-      jsi::Value createOscillator(jsi::Runtime& runtime, const jsi::PropNameID& propNameId);
-      jsi::Value getDestination(jsi::Runtime& runtime, const jsi::PropNameID& propNameId);
   };
 } // namespace audiocontext