fix: fix merge unwanted changes

software-mansion-labs · Jul 25, 2024 · 9749b8d · 9749b8d
1 parent 92568e0
commit 9749b8d
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 30 deletions.
diff --git a/cpp/OscillatorNode/OscillatorNodeWrapper.h b/cpp/OscillatorNode/OscillatorNodeWrapper.h
@@ -17,10 +17,6 @@ namespace audiocontext {
     class OscillatorNodeWrapper: public AudioNodeWrapper {
 #ifdef ANDROID
         std::shared_ptr<OscillatorNode> oscillator_;
-#else
-        std::shared_ptr<IOSOscillator> oscillator_;
-#endif
-
     public:
         explicit OscillatorNodeWrapper(const std::shared_ptr<OscillatorNode> &oscillator) : AudioNodeWrapper(
                 oscillator), oscillator_(oscillator) {}

diff --git a/example/src/App.tsx b/example/src/App.tsx
@@ -32,7 +32,8 @@ const App: React.FC = () => {
 
     if (Platform.OS === 'android') {
       const destination = audioContextRef.current.destination;
-      oscillatorRef.current.connect(destination!);
+      oscillatorRef.current.connect(gainRef.current);
+      gainRef.current.connect(destination!);
     }
   };
 
@@ -90,7 +91,7 @@ const App: React.FC = () => {
         />
       </View>
       <View style={styles.container}>
-        <Text>Gain: {gain.toFixed(1)}</Text>
+        <Text>Gain: {gain.toFixed(2)}</Text>
         <Slider
           containerStyle={styles.slider}
           value={gain}

diff --git a/src/AudioContext.ts b/src/AudioContext.ts
diff --git a/src/modules/global.d.ts b/src/modules/global.d.ts
@@ -2,6 +2,7 @@ import type { Oscillator } from '../types';
 
 type AudioContext = {
   createOscillator: () => Oscillator;
+  createGain: () => Gain;
   destination: AudioDestinationNode | null;
 };