fix: correct buffer lengths on real ios devices (#231)

software-mansion-labs · Dec 10, 2024 · 7fd138a · 7fd138a
1 parent ef4327d
commit 7fd138a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/packages/react-native-audio-api/common/cpp/core/AudioDestinationNode.cpp b/packages/react-native-audio-api/common/cpp/core/AudioDestinationNode.cpp
@@ -31,6 +31,7 @@ void AudioDestinationNode::renderAudio(
   }
 
   context_->getNodeManager()->preProcessGraph();
+
   destinationBus->zero();
 
   AudioBus *processedBus = processAudio(destinationBus, numFrames);

diff --git a/packages/react-native-audio-api/common/cpp/core/BaseAudioContext.cpp b/packages/react-native-audio-api/common/cpp/core/BaseAudioContext.cpp
@@ -120,7 +120,7 @@ std::shared_ptr<AudioBuffer> BaseAudioContext::decodeAudioDataSource(
 #endif
 
 std::function<void(AudioBus *, int)> BaseAudioContext::renderAudio() {
-  if (isClosed()) {
+  if (!isRunning()) {
     return [](AudioBus *, int) {};
   }
 

diff --git a/packages/react-native-audio-api/ios/AudioPlayer/AudioPlayer.m b/packages/react-native-audio-api/ios/AudioPlayer/AudioPlayer.m
@@ -62,7 +62,8 @@ - (int)getBufferSizeInFrames
   // which is safer to base our internal AudioBus sizes.
   // Buut no documentation => no guarantee :)
   // If something is crackling when it should play silence, start here 📻
-  return (int)(self.audioSession.preferredIOBufferDuration * self.audioSession.sampleRate);
+  double maxBufferDuration = fmax(0.02, fmax(self.audioSession.IOBufferDuration, self.audioSession.preferredIOBufferDuration));
+  return (int)(maxBufferDuration * self.audioSession.sampleRate + 1);
 }
 
 - (void)start
-Original file line number
+Diff line change
@@ Expand Up / @@ -31,6 +31,7 @@ void AudioDestinationNode::renderAudio( @@
       }
       context_->getNodeManager()->preProcessGraph();
       destinationBus->zero();
       AudioBus *processedBus = processAudio(destinationBus, numFrames);
@@ Expand Down @@