refactor: code review changes

software-mansion-labs · Jul 25, 2024 · 276d5f0 · 276d5f0
1 parent 1e61c13
commit 276d5f0
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 29 deletions.
diff --git a/android/CMakeLists.txt b/android/CMakeLists.txt
@@ -28,7 +28,7 @@ add_library(react-native-audio-context SHARED
         src/main/cpp/OnLoad.cpp
         src/main/cpp/AudioContext
         src/main/cpp/OscillatorNode
-        src/main/cpp/AudioDestinationNode
+        src/main/cpp/AudioDestinationNode.h
         src/main/cpp/AudioNode
         src/main/cpp/GainNode
 

diff --git a/android/src/main/cpp/AudioDestinationNode.cpp b/android/src/main/cpp/AudioDestinationNode.cpp
diff --git a/example/src/App.tsx b/example/src/App.tsx
@@ -35,17 +35,27 @@ const App = () => {
     gainRef.current.connect(destination);
   };
 
-  const handleSliderChange = (
-    value: number[],
-    defaultValue: number,
-    setValue: (value: number) => void,
-    ref: React.MutableRefObject<{ [key: string]: any } | null>,
-    propName: string
-  ) => {
-    const newValue = value[0] || defaultValue;
-    setValue(newValue);
-    if (ref.current) {
-      ref.current[propName] = newValue;
+  const handleGainChange = (value: number[]) => {
+    const newValue = value[0] || 0.0;
+    setGain(newValue);
+    if (gainRef.current) {
+      gainRef.current.gain = newValue;
+    }
+  };
+
+  const handleFrequencyChange = (value: number[]) => {
+    const newValue = value[0] || 440;
+    setFrequency(newValue);
+    if (oscillatorRef.current) {
+      oscillatorRef.current.frequency = newValue;
+    }
+  };
+
+  const handleDetuneChange = (value: number[]) => {
+    const newValue = value[0] || 0;
+    setDetune(newValue);
+    if (oscillatorRef.current) {
+      oscillatorRef.current.detune = newValue;
     }
   };
 
@@ -83,28 +93,18 @@ const App = () => {
         <Slider
           containerStyle={styles.slider}
           value={gain}
-          onValueChange={(value) =>
-            handleSliderChange(value, 0.0, setGain, gainRef, 'gain')
-          }
+          onValueChange={handleGainChange}
           minimumValue={0.0}
           maximumValue={1.0}
-          step={0.1}
+          step={0.01}
         />
       </View>
       <View style={styles.container}>
         <Text>Frequency: {frequency.toFixed(0)}</Text>
         <Slider
           containerStyle={styles.slider}
           value={frequency}
-          onValueChange={(value) =>
-            handleSliderChange(
-              value,
-              440,
-              setFrequency,
-              oscillatorRef,
-              'frequency'
-            )
-          }
+          onValueChange={handleFrequencyChange}
           minimumValue={120}
           maximumValue={1200}
           step={10}
@@ -115,9 +115,7 @@ const App = () => {
         <Slider
           containerStyle={styles.slider}
           value={detune}
-          onValueChange={(value) =>
-            handleSliderChange(value, 0, setDetune, oscillatorRef, 'detune')
-          }
+          onValueChange={handleDetuneChange}
           minimumValue={0}
           maximumValue={100}
           step={1}