forked from Expensify/App
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poc/split navs #101
Draft
adamgrzybowski
wants to merge
277
commits into
main
Choose a base branch
from
poc/split-navs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,166
−3,370
Draft
Poc/split navs #101
Changes from all commits
Commits
Show all changes
277 commits
Select commit
Hold shift + click to select a range
7e483b7
Handle deeplinking to report with policyID in URL
WojtekBoman 82d6df1
Test freezing split navigators
WojtekBoman d2ba718
Remove state listener from FreezeWrapper
WojtekBoman 83c94a6
Freeze WorkspaceSplitNavigator
WojtekBoman 9ddd42c
Replace FullScreenNavigator with SplitNavigator
WojtekBoman 4e72842
Rename Split to SplitStack
WojtekBoman 8b590d1
Rename useNavigationReset to useHandleScreenResize
WojtekBoman 72dbdf1
Rename FullScreenNavigator to WorkspaceNavigator
WojtekBoman 557d7aa
Add BottomTabBar to WorkspaceInitialPage and SettingsWorkspaces
WojtekBoman ac3fc8f
Fix pressing settings tab when navigating deeper into workspaces
WojtekBoman ae70ac4
fix pressing on settings tab while in workspace navigator
adamgrzybowski 19bf5d9
Add todo comments for new navigation logic, adjust split navigators, …
WojtekBoman fdb6e13
Refactor useActiveWorkspace
WojtekBoman 0488fd2
Add createSplitNavigator
WojtekBoman bc2adfe
improve routers
adamgrzybowski 6d6d0ab
add setter to activeWorkspaceID context
adamgrzybowski 40e6e1e
Fix LHN paddings
WojtekBoman 9ff0e05
remember state between tabs
adamgrzybowski 0a374cc
Disable animation for settings workspaces screen
WojtekBoman 51895f5
Add getStateToRender to createSplitStackNavigator, splits types fixes
WojtekBoman 44b9c7b
Fix switching between home and workspace settings
WojtekBoman 3ba0aaf
Fix navigating from BottomTabAvatar when current route is WorkspaceIn…
WojtekBoman 32288b1
Fix flickering in frozen split navigators
WojtekBoman 784cf89
Fix lint in createCustomStackNavigator/index.tsx
WojtekBoman a1d9a3a
Add missing import to AuthScreens, fix styles in SearchPage
WojtekBoman 5bb5b16
Fix styles in SearchPage
WojtekBoman 94aaab1
move all mappings to one directory RELATIONS
adamgrzybowski d499b5c
remove old linkTo
adamgrzybowski 18216bc
refactor getAdaptedState
adamgrzybowski 98127ae
Merge pull request #106 from software-mansion-labs/poc/split-adapted-…
adamgrzybowski 6860510
fix prettier
adamgrzybowski 5f6fe49
Remove w param from navigate when navigating to chats from bottom tab
WojtekBoman 4fe5789
Add template of goUp
WojtekBoman cf25855
Handle navigating back to sidebar screen
WojtekBoman e2a304e
Replace FullScreenNavigator with SplitNavigator
WojtekBoman a3f95c8
Rename Split to SplitStack
WojtekBoman 665f795
Rename FullScreenNavigator to WorkspaceNavigator
WojtekBoman ab72ccc
Add BottomTabBar to WorkspaceInitialPage and SettingsWorkspaces
WojtekBoman a9d0bf8
Add todo comments for new navigation logic, adjust split navigators, …
WojtekBoman 9c7967a
Refactor useActiveWorkspace
WojtekBoman af90faf
Add createSplitNavigator
WojtekBoman 097a82a
improve routers
adamgrzybowski f398653
add setter to activeWorkspaceID context
adamgrzybowski 58be5b5
Fix LHN paddings
WojtekBoman 0f9efb9
remember state between tabs
adamgrzybowski 9148db3
Test freezing split navigators
WojtekBoman d74d1eb
Fix flickering in frozen split navigators
WojtekBoman 3d73e89
Fix types in getMinimalAction and goUp functions
WojtekBoman b2aedc2
Fix replacing a sidebar screen in split navigators
WojtekBoman 38d466f
Adjust Navigation.resetToHome to work with SplitNavigators
WojtekBoman e2ad744
Replace some usages of resetToHome with goUp(ROUTES.HOME)
WojtekBoman 53fe13e
Cleanup linkTo and getMinimalAction
WojtekBoman 05d529a
Cleanup navigation changes
WojtekBoman ece8857
Remove mappings from linkingConfig
WojtekBoman 8b44987
Merge pull request #105 from software-mansion-labs/poc/split-go-up
WojtekBoman 741c10d
fix mapping and SplitStackRouter
adamgrzybowski a6c28f8
remove dismissModalWithReport
adamgrzybowski 47c8e0b
resolve some todos
adamgrzybowski 4b1cedd
bring back stateToRender
adamgrzybowski 8b7e4a0
Add PARAMS_TO_OMIT_WHEN_COMPARING_ROUTES
WojtekBoman 222e8ad
Remove unused files, fix lint and typescript errors
WojtekBoman b83d53d
Remove remaining occurences of Navigation.closeAndNavigate
WojtekBoman a214ae0
Fix animation when navigating to central screen of split navigator
WojtekBoman d7bd472
Fix customGetPathFromState
WojtekBoman 00001dd
add optimization for root navigator
adamgrzybowski 93eb244
remove FreezeWrapper
adamgrzybowski 7b36a3b
Add tests section to the NAVIGATION.md
WojtekBoman 59df51e
Merge pull request #107 from software-mansion-labs/poc/split-perf
adamgrzybowski 65c5468
Merge branch 'main' into poc/split-navs
WojtekBoman 9e34f96
Add freezing sidebar screen
WojtekBoman 63fed48
Dont freeze sidebar screen when modal navigator is above in the navig…
WojtekBoman 413e777
Fix navigating from SearchRouterList to chat
WojtekBoman d2e2119
Handle deeplinking to the url with policyID
WojtekBoman 3d9199c
Remove unused code, add fixes to search
WojtekBoman 1e1e06b
Fix sidebar tests
WojtekBoman cd5cf44
Add ts fixes
WojtekBoman 45dd97a
Migrate FloatingActionButton to useOnyx and add small cleanups
Kicu 74f8e18
Add lint fixes
WojtekBoman 564fe9e
Merge pull request #109 from software-mansion-labs/kicu/poc/migrate-fab
Kicu 9aed8a0
Remove shouldEnforceFallback param, add comments
WojtekBoman a8b8d0d
Merge pull request #108 from software-mansion-labs/poc/split-navs-fre…
adamgrzybowski dc6dfc2
Refactor comments about goBack
WojtekBoman ee31d12
Fix passing policyID to ReportsSplitNavigator when opening app from d…
WojtekBoman b6b4ad8
Fix passsing backTo from SCREENS.WORKSPACE.PROFILE to SCREENS.WORKSPA…
WojtekBoman 3dfd640
Merge pull request #110 from software-mansion-labs/poc/split/checks
WojtekBoman 356519c
changes in doc
adamgrzybowski 481f591
Refactor variables names in customGetPathFromState
WojtekBoman cbae813
Merge pull request #111 from software-mansion-labs/poc/set-policyID-i…
WojtekBoman 0cdad81
Merge branch 'main' into poc/split-navs
WojtekBoman 2f137ca
Fix getting topmost route in AddPersonalBankAccountPage, add todo com…
WojtekBoman e6a4c54
Fix ts in getStateToRender in createSplitStackNavigator/index.tsx
WojtekBoman b9fff42
Merge branch 'main' into poc/split-navs
WojtekBoman 2391422
Merge pull request #112 from software-mansion-labs/poc/docs
adamgrzybowski c7f7040
fix perf and matching central screen after deeplink
adamgrzybowski e07125b
Merge pull request #113 from software-mansion-labs/poc/perf-and-match…
adamgrzybowski 0612b54
Fix displaying active tab when search is opened
WojtekBoman dcdf021
Refactor isSplitNavigatorRoute and isFullScreenRoute
WojtekBoman 9efb031
Fix navigating to previously opened settings tab
WojtekBoman 4881e68
Remove getTopMostCentralPaneRouteFromRootState from Navigation.ts
WojtekBoman 31069c1
fix getRouteParamsToCompare
adamgrzybowski 75c4b80
fix goUp on WorkspaceListPage
adamgrzybowski e69c349
fix animation for navigating to WorkspadceListPage
adamgrzybowski d6f3322
remove unused code
adamgrzybowski 03bd743
fix animation for navigating to Sidebar screens
adamgrzybowski 90b5e67
Merge branch 'poc/split-navs' into poc/fixes
adamgrzybowski 5f09a69
Merge pull request #114 from software-mansion-labs/poc/fixes
adamgrzybowski e56bdaa
Revert "Migrate FloatingActionButton to useOnyx and add small cleanups"
adamgrzybowski a0b5c50
Merge branch 'main' into poc/split-navs
adamgrzybowski e8b58f8
Merge branch 'main' into poc/split-navs
adamgrzybowski b16a7ca
fix SETTINGS_TO_RHP
adamgrzybowski 9132ffd
fix perf tests
adamgrzybowski 0fc9470
fix perf tests v2
adamgrzybowski b23a3f1
Fix bottom tab width in InitialSettingsPage
WojtekBoman a95797c
Remove some todo comments
WojtekBoman 052d352
Fix getting previousSelectedCentralScreen in adaptStateIfNecessary
WojtekBoman 6701e9f
Remove money request rhp screens from SIDEBAR_TO_RHP
WojtekBoman a3063c8
Fix issue: Expense - App does not open destination report after submi…
WojtekBoman d0a1b69
fix: Attachment - New attachment window is opened when switching betw…
adamgrzybowski 0ab9076
Fix issue: Android - No animation when navigating in and out of works…
WojtekBoman f4dd1bf
Fix issue: Web - Hold - App flickers after entering reason and saving…
WojtekBoman 927c68b
Fix issue: Group - App returns to group settings page after saving gr…
WojtekBoman 8cd6ade
Adjust getTopmostReportActionID and cleanup getTopmostReportID
WojtekBoman 37b5cc0
Merge pull request #116 from software-mansion-labs/poc/fix-attachments
adamgrzybowski 072ea6a
Fix issue: QBO - Preferred exporter/Export date tab do not auto-close…
WojtekBoman 2d30771
Add test steps for issues related to split navigators
WojtekBoman eb35ca7
Merge pull request #117 from software-mansion-labs/poc/split-dismiss-…
WojtekBoman 34b56d9
Merge branch 'main' into poc/split-navs
WojtekBoman fac8f6f
fix: Book travel - Unable to select country in company address page
adamgrzybowski eb8c882
add tests for: Attachment - New attachment window is opened when swit…
adamgrzybowski 79a508f
Merge pull request #118 from software-mansion-labs/poc/fix-country-pi…
adamgrzybowski ec4a01e
Web - Thread - Highlighted message is not dismissed after clicking on…
adamgrzybowski 287d7ed
fix typo
adamgrzybowski e8cc9c3
add test
adamgrzybowski be7fe0d
Merge pull request #119 from software-mansion-labs/poc/link-to-reports
adamgrzybowski 868b305
Fix issue: BA - Back button on connect bank account modal opens incor…
WojtekBoman fb326c3
fix passing params from rhp in adapted state
adamgrzybowski b9a1119
fix Search - App returns to Inbox after deleting expense from report …
adamgrzybowski 0f46afb
Merge pull request #120 from software-mansion-labs/poc/fix-adapted-st…
adamgrzybowski c1d813f
Merge pull request #121 from software-mansion-labs/poc/fix-navigation…
WojtekBoman 223e383
Merge branch 'main' into poc/split-navs
WojtekBoman 30c9748
add comments to RELATIONS files
adamgrzybowski 8fcd73c
fix Submitting expense flow from tabs different than inbox
adamgrzybowski 84f1543
remove forRoute suffix
adamgrzybowski 21e1863
add tests
adamgrzybowski 86fb765
Merge pull request #122 from software-mansion-labs/poc/fix-default-route
adamgrzybowski 92e47ac
Fix issue: Android - Offline indicator is below the app navigation bar
WojtekBoman 8ddbd8e
Merge pull request #123 from software-mansion-labs/poc/split-flix-ban…
adamgrzybowski f4d7f2e
Fix issue: Expensify Card - App crashes when opening fields in Card d…
WojtekBoman 4c7c320
Fix issue: Expensify Card - Back button on profile returns to member …
WojtekBoman 6dde5fd
Fix issue: Workflow - Not here Page appears when editing first approver
WojtekBoman dfdd15d
Fix issue: Android - Expensify card - Directed to connect bank accoun…
WojtekBoman 27a356d
Add a test for bank account flow
WojtekBoman e528b6a
Merge pull request #124 from software-mansion-labs/poc/split-bank-acc…
WojtekBoman 8fa61a2
Fix issue: App opens room details page when tapping RHP back button a…
WojtekBoman 9fd294b
Fix counting distanceToPop in goBack
WojtekBoman 75c3f18
Fix fallbackRoute in selectExportDate in QuickbooksExportDateSelectPage
WojtekBoman 0ad8a87
Merge branch 'main' into poc/split-navs
WojtekBoman 8e44d87
Adjust goUp to handle navigating back when targetState is rootState
WojtekBoman ed0ebca
Merge pull request #129 from software-mansion-labs/poc/fix-go-up
adamgrzybowski 4c2c180
Fix issue: Track expense - Member list opens again after clicking bac…
WojtekBoman 65b6c89
Adjust getAdaptedState to handle OnboardingModalNavigator
WojtekBoman 6f65c7c
Fix issue: Group chat - Default group chat name when created offline …
WojtekBoman b213f93
Add test steps for the issue: Opening particular onboarding pages fro…
WojtekBoman 33d6012
Merge pull request #130 from software-mansion-labs/poc/split-navs-ada…
WojtekBoman 0c90d16
Merge branch 'main' into poc/split-navs
WojtekBoman 44bde76
Fix issue: Expense - Report details RHP opens after deleting receipt
WojtekBoman 6fc9f27
adjust navigation patch for new screens and navigators
adamgrzybowski c52cbaa
implement new freeze wrapper
adamgrzybowski dab0ad4
use new freeze wrapper
adamgrzybowski 4dbdd23
Merge pull request #134 from software-mansion-labs/poc/freeze-perf
adamgrzybowski a455bac
Merge branch 'main' into poc/split-navs
WojtekBoman f6084ec
Adjust getIsScreenBlurred to native platforms
WojtekBoman 122fc6a
Merge pull request #135 from software-mansion-labs/poc/adjust-get-is-…
WojtekBoman 43f48d3
Make ReportsSplitNavigator public
WojtekBoman b5eb92b
Refactor the comment about state reset after logout
WojtekBoman 4cb080c
Merge pull request #137 from software-mansion-labs/poc/split-login-pa…
WojtekBoman 34d6403
Cleanup ActiveWorkspaceProvider
WojtekBoman 0cd11da
Fix animationTypeForReplace for RHP screens
WojtekBoman 5d978e3
Add GetStateForActionHandlers
WojtekBoman 99166de
Fix ParamList in WorkspacePerDiemPage
WojtekBoman 061f2ca
Fix types in RELATIONS and getAdaptedStateFromPath
WojtekBoman 3659ad0
Remove @todo comment from getAdaptedStateFromPath
WojtekBoman 62b1cda
Remove NAVIGATION.TYPE.UP
WojtekBoman 20efb77
Remove passing CONST.NAVIGATION.ACTION_TYPE.PUSH as a type param to N…
WojtekBoman 2df2704
Fix lint in CustomRouter.ts
WojtekBoman 4849fb7
Rename shouldDismissSideModalNavigator to isNavigatingToModalFromModal
WojtekBoman 0de350b
Merge pull request #138 from software-mansion-labs/poc/split-cleanup
WojtekBoman e211447
Replace isSearchTopmostRoute with isSearchTopmostFullScreenRoute
WojtekBoman a846373
Cleanup handleDismissModalAction
WojtekBoman 954a411
Merge branch 'main' into poc/split-merge-native-stacks
WojtekBoman c7c315e
Adjust split router to native stack
WojtekBoman 785259f
Merge pull request #147 from software-mansion-labs/poc/split-merge-na…
WojtekBoman 9765499
Adjust PlatformStackNavigator typescript and styles to SplitNavigators
WojtekBoman 37203aa
Remove searchRoute from PlatformStack types
WojtekBoman 741ce5f
Add getSplitNavigatorOptions
WojtekBoman 899084b
Add parentRoute to CustomCodeProps
WojtekBoman 861f87a
Fix lint
WojtekBoman 2e212a7
Merge pull request #149 from software-mansion-labs/poc/split-adjust-t…
WojtekBoman 93fa76d
Remove BOTTOM_TAB, cleanup code related to SplitNavigators
WojtekBoman 4ace213
Cleanup config.ts
WojtekBoman fd99fa8
Remove subscribe
WojtekBoman d54df17
Remove Navigation.removeScreenFromNavigationState
WojtekBoman 9280e9e
Fix typo in NavigationUtils.ts
WojtekBoman 9fbccec
Add navigation helpers
WojtekBoman be9cb55
Move navigation functions to helpers package
WojtekBoman e8749f4
Make goUp private
WojtekBoman 3ed172e
Rename SplitNavigatorLHNScreen to SplitNavigatorSidebarScreen
WojtekBoman dd7a57c
Rename createSplitNavigator to getInitialSplitNavigatorState
WojtekBoman 2afede2
Fix goBack calls with shouldPopToTop
WojtekBoman 3afe817
Remove LHN_TO_SPLIT_NAVIGATOR_MAPPING
WojtekBoman 324b598
Cleanup navigation types and remove redundant mapping files
WojtekBoman f44db08
Add missing docs to navigation functions
WojtekBoman 216c812
Cleanup isNavigatorName
WojtekBoman f46818a
Adjust comment in SIDEBAR_TO_RHP
WojtekBoman 7cf08be
Refactor getTopmostReportParam to getTopmostReportParams
WojtekBoman 21f7bf6
Adjust getOnboardingAdaptedState docs
WojtekBoman b11cba2
Adjust screen navigation props types
WojtekBoman b15bcca
Rename SplitStack to Split
WojtekBoman e69b8f0
Fix tests that use useActiveWorkspace
WojtekBoman 2896031
Fix mocking isSearchTopmostFullScreenRoute in IOUTest
WojtekBoman 686dde6
Update relations files and remove redundant mappings
WojtekBoman d7d0ff3
Add popToTop method to Navigation.ts
WojtekBoman 097d3c5
Unification of comments in Navigation.ts
WojtekBoman 0ae4aac
Fix goBack in navigateToConciergeChatAndDeleteReport
WojtekBoman 7345d80
Merge pull request #142 from software-mansion-labs/poc/bottom-tab-cle…
WojtekBoman ade9a19
Merge branch 'main' into poc/split-navs
WojtekBoman 27c6f92
Simplify ActiveWorkspaceContextProvider
WojtekBoman 96289b1
Adjust BaseSidebarScreen workspace reset hook to split navigators
WojtekBoman 18ad376
Remove Navigation.switchPolicyID
WojtekBoman 14068c4
Adjust createInverseRelation, fix SPLIT_TO_SIDEBAR
WojtekBoman 0a11e29
Fix Navigation.popToTop
WojtekBoman 5117a9f
Adjust ResizeScreenTests to SplitNavigator structure
WojtekBoman 08f5c9d
Fix goBack types
WojtekBoman 579608e
Remove useNavigationResetRootOnLayoutChange
WojtekBoman 79202d1
Fix go back using swipe from not found policy page
WojtekBoman 9f5bccb
Hide bottom tab on workspace initial page when policy is not found
WojtekBoman faeaf9a
Simplify getAdaptedState
WojtekBoman e7a5150
Add comment to NAVIGATORS.WORKSPACE_SPLIT_NAVIGATOR linking config
WojtekBoman 49c49f9
Handle adding SettingsSplit under WorkspaceSplit in getAdaptedState
WojtekBoman 4620ac7
Add shouldDisplayPolicyNotFoundPage
WojtekBoman f405f7e
Simplify getRoutePolicyID
WojtekBoman 2e08e1e
Remove backTo param from Workspace Initial Page
WojtekBoman 3e7f16c
Merge pull request #154 from software-mansion-labs/poc/fix-adapt-state
adamgrzybowski c611aa2
fix copying params for sidebar in adaptStateIfNecessary
adamgrzybowski 7438d33
implement TopLevelBottomTabBar and proper animations
adamgrzybowski 88b9998
Merge pull request #155 from software-mansion-labs/poc/top-level-bott…
adamgrzybowski 28ed8b9
Merge branch 'main' into poc/split-navs
WojtekBoman 99fc247
Fix lint
WojtekBoman 17759f4
Remove Navigation.popToTop and add shouldPopToTop to GoBackOptions
WojtekBoman 1480723
Fix types in getAdaptedStateFromPath
WojtekBoman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,8 @@ | ||
import {createContext} from 'react'; | ||
|
||
type ActiveWorkspaceContextType = { | ||
activeWorkspaceID?: string; | ||
setActiveWorkspaceID: (activeWorkspaceID?: string) => void; | ||
}; | ||
|
||
const ActiveWorkspaceContext = createContext<ActiveWorkspaceContextType>({activeWorkspaceID: undefined, setActiveWorkspaceID: () => undefined}); | ||
const ActiveWorkspaceContext = createContext<{activeWorkspaceID: string | undefined; setActiveWorkspaceID: (workspaceID: string | undefined) => void}>({ | ||
activeWorkspaceID: undefined, | ||
setActiveWorkspaceID: () => {}, | ||
}); | ||
|
||
export default ActiveWorkspaceContext; | ||
export {type ActiveWorkspaceContextType}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember to remove unused pages/navigators before merging