Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wrong card playable) #84

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

Vito0912
Copy link
Contributor

@Vito0912 Vito0912 commented Oct 18, 2024

Description

Resolved an issue where the SwapCarrots card could be played when it shouldn't have been allowed.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

I played several rounds, and the error reported on Discord did not occur. However, I did not specifically test for that particular issue as I found no way of creating a game that has this condition.

What Has Been Changed?

Added a constant lettuce position (as it does not change). And fixed the condition in which when a player was on a lattuce the check was okay but it should report that it was not

Checklist:

  • My code follows the style guidelines of this project (hopefully)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas (self-explaining)
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Resolved an issue where the SwapCarrots card could be played when it shouldn't have been allowed.
Copy link
Collaborator

@maxblan maxblan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your work!
The only suggestion I have is to put the lettuce index constant into the constants.rs.
I will do this myself to speed up the process.

@maxblan maxblan merged commit 975a595 into software-challenge:master Oct 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants