-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate concerns of Player object #229
base: main
Are you sure you want to change the base?
Conversation
Do you think it makes sense to update this PR? |
Well the general premise should be implemented - having separate player classes for network client vs an entity that plays. But I guess starting from scratch would be faster. Until then we can keep this as reference. |
I'm looking into what can be done right now. As I see it, we need to move the Team/PlayerColor stuff into the game plugin (since the way that teams / colours are defined differs between the games) and only leave the player representing the client in the sdk |
Well, for all games so far the color was an identifying feature of the player, I think this is the first one where it is different - so the perfect time to rethink the architecture ;) |
yes, as I already mentioned. |
e4240d9
to
040b96b
Compare
The Player object right now is a big mess, it handles color, name, listeners and reporting invalid player moves. I want to separate these concerns with this PR.