fix: middleware message handling #28
Open
+103
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paupm
reviewed
Jan 31, 2025
pkg/middleware/unimplemented.go
Outdated
| _, err = (*b.client).Handle(context.Background(), req) | ||
| return nil, err | ||
| klog.V(0).Info("processing next middleware") | ||
| ctxTimeout, cancelTimeout := context.WithTimeout(context.Background(), 12*time.Second) |
There was a problem hiding this comment.
Shouldn't we add the retry config here too?
There was a problem hiding this comment.
default retry policy is added when creating the client for the next middleware in this file, you mean that?
There was a problem hiding this comment.
Now I've seen the defaultRetryPolicy variable use, thanks :-)
| klog.Errorf("Failed to remove socket: %v", err) | ||
| } | ||
|
|
||
| err = os.MkdirAll(filepath.Dir(socket), 0775) |
There was a problem hiding this comment.
Where is the socket folder created now?
There was a problem hiding this comment.
we don't need to, do we?
There was a problem hiding this comment.
I think so, you don't know the socket path you are receiving, so, How do you know it is created?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix some issues related to middleware message handling:
Additionally: