[Refactor] quiz exception 및 에러 logger 추가 #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- DB에서 찾은 quiz가 null일때 체크 후 exception 추가 - exception handler에 해당 exception 추가 및 ErrorCode 추가
eckrin
approved these changes
Aug 19, 2024
| @@ -36,6 +36,7 @@ public CompletableFuture<CommonResponse<ArrivalApplicationResponseDto>> arrivalE | |||
| if(ex.getCause() instanceof ExistingUserException) { | |||
| throw new ExistingUserException("[비동기 에러] 유저가 이미 존재합니다."); | |||
| } else { | |||
| log.error("Exception occurred while arrival application", ex); | |||
There was a problem hiding this comment.
여기 에러가 실제로 뜨나요? Logger 문법이 이렇게도 되는지 궁금합니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 이슈 번호
x
💡 작업 내용
💡 자세한 설명
DailyQuizNotExistsException 추가 및 service 단에서 에러 검출 추가
선착순 응모 api에서 exception 발생 시 해당 exception을 logger로 출력
📗 참고 자료 (선택)
📢 리뷰 요구 사항 (선택)
🚩 후속 작업 (선택)
✅ 셀프 체크리스트