Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Redis, Java 선착순 통합/단위 테스트 #23

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

eckrin
Copy link
Collaborator

@eckrin eckrin commented Aug 16, 2024

🎯 이슈 번호

Issue #38

💡 작업 내용

  • Redis 선착순 통합/단위 테스트
  • Java 선착순 통합/단위 테스트
  • 당첨자수 세팅 스케줄링 테스트

✅ 셀프 체크리스트

  • PR 제목을 형식에 맞게 작성했나요?
  • 브랜치 전략에 맞는 브랜치에 PR을 올리고 있나요? (master/main이 아닙니다.)
  • Reviewers, Labels, Projects를 등록했나요?
  • 작업 도중 문서 수정이 필요한 경우 잘 수정했나요?
  • 테스트는 잘 통과했나요?
  • 불필요한 코드는 제거했나요?

eckrin added 3 commits August 15, 2024 18:01
- TestConfig를 통해서 테스트별로 다른 구현체를 주입받도록 수정
- @DirtiesContext를 사용하여 테스트마다 redissonClient 컨텍스트 초기화
@eckrin eckrin self-assigned this Aug 16, 2024
@eckrin eckrin added the enhancement New feature or request label Aug 16, 2024
public ArrivalEventService arrivalEventJavaService(ArrivalEventReleaseServiceJavaImpl arrivalEventReleaseServiceJavaImpl) {
return new ArrivalEventService(arrivalEventReleaseServiceJavaImpl);
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이런식으로도 bean을 임시로 등록해서 테스트해볼 수 있군요. 많이 배웠습니다.

Copy link
Collaborator

@luna156 luna156 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 것 같습니다. 머지하면 될 것 같아요. 수고하셨습니다

@eckrin eckrin merged commit 858f634 into master Aug 16, 2024
1 check passed
@eckrin eckrin deleted the test/arrival-java branch August 16, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants