[Feat] RushEvent 컴포넌트 구현 #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
빌드를 성공했습니다! 🎉 |
|
빌드를 성공했습니다! 🎉 |
jhj2713
approved these changes
Jul 30, 2024
| @@ -0,0 +1,8 @@ | |||
| export const formatDate = (dateString: string): string => { | |||
| const date = new Date(dateString); | |||
There was a problem hiding this comment.
이때 date 포맷이 아닌 string이 들어오는 경우에 대한 예외처리를 해줘도 좋을 것 같아욥!
client/src/utils/formatDate.ts
Outdated
| const date = new Date(dateString); | ||
| const month = date.getMonth() + 1; | ||
| const day = date.getDate(); | ||
| const dayOfWeek = ["일", "월", "화", "수", "목", "금", "토"][date.getDay()]; |
There was a problem hiding this comment.
Suggested change
| const dayOfWeek = ["일", "월", "화", "수", "목", "금", "토"][date.getDay()]; | |
| const DAY_OF_WEEK = ["일", "월", "화", "수", "목", "금", "토"]; | |
| ... | |
| const today = dayOfWeek[date.getDay()]; |
["일", "월", "화", "수", "목", "금", "토"]랑 index가 바로 붙어있으니까 쪼금 헷갈리는 것 같아서 위 예시처럼 따로 상수로 빼주는게 좀 더 가독성이 좋지 않을까 하는 생각입니덩
There was a problem hiding this comment.
역시!! 너무 좋은생각입니다 :) 리팩토링 여신님 말따르겠습니다!
| className={`relative w-[160px] h-[200px] py-7 px-5 rounded-500 bg-n-white flex flex-col gap-4 justify-between items-center border ${borderClass} ${opacityClass}`} | ||
| > | ||
| <p | ||
| className={`h-body-2-bold ${isTodayEvent ? "text-s-red" : "text-n-neutral-950"} text-nowrap`} |
There was a problem hiding this comment.
요 삼항 연산자도 borderClass나 opacityClass 처럼 빼주는게 통일성 있지 않을까 싶어용
|
빌드를 성공했습니다! 🎉 |
|
빌드를 성공했습니다! 🎉 |
|
빌드를 실패했습니다. ❌ 자세한 내용은 로그를 참고해주세요. |
|
빌드를 성공했습니다! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🖥️ Preview
✏️ 한 일
close 선착순 이벤트 경품 컴포넌트 구현 #58
❗️ 발생한 이슈 (해결 방안)
👺 커밋명 하나 잘못 올려버렸다..
refactor: lotteryEventData storybook 경로 수정
-> feat: RushEvent 컴포넌트 UI 구현
❓ 논의가 필요한 사항