[Feat] Navigation Block 팝업 커스텀 구현 #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
빌드를 성공했습니다! 🎉 |
sooyeoniya
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🖥️ Preview
close #191
✏️ 한 일
❗️ 발생한 이슈 (해결 방안)
기존에는 usePrompt를 사용해서 window 기본 confirm 창 기반으로 뒤로가기를 방지했지만 기본 confirm 창보다는 커스텀한 Popup이 나을 것이라고 판단해 useBlocker를 사용해서 커스텀을 진행했습니다.
NavigationConfirmPopUp이 생기면서 기존의 PopUp의 역할이 구체적으로 명시되는게 좋을 것 같아서PhoneNumberPopUp으로 컴포넌트 명을 수정했습니다.❓ 논의가 필요한 사항