[Fix] Transition 버벅임 문제 해결 #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
빌드를 성공했습니다! 🎉 |
|
빌드를 성공했습니다! 🎉 |
jhj2713
commented
Aug 20, 2024
| <TransitionCasperCardItem | ||
| key={`${card.id}-${idx}`} |
There was a problem hiding this comment.
key에 index까지 추가해두면 배열에 새로운 카드가 추가될 때마다 key값이 바껴서 모든 배열이 리렌더링이 발생해서 idx는 삭제,,
sooyeoniya
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🖥️ Preview
as-is
2024-08-20.10.55.15.mov
to-be
2024-08-20.11.33.39.mov
close #176
✏️ 한 일
❗️ 발생한 이슈 (해결 방안)
기존에 사용했던 사용해서
visibleCardCount * 2만큼 렌더링 후 리스트 목록을 갈아끼우는 방식이 불필요한 렌더링을 유발하고 목록을 갈아끼우는 과정에서 버벅임이 발생하는 문제가 있었습니다.따라서 배열을 갈아끼우지 않고 화면에 보이는 카드들만 렌더링할 수 있도록 Windowing 방식을 수정했습니다. >> 관련 wiki
❓ 논의가 필요한 사항