[Feat] RushCard 색상 랜덤 기능 구현 #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
빌드를 성공했습니다! 🎉 |
jhj2713
reviewed
Aug 19, 2024
| @@ -0,0 +1,16 @@ | |||
| import { CARD_COLOR } from "@/constants/Rush/rushCard.ts"; | |||
|
|
|||
| export function getRandomCardColors() { | |||
There was a problem hiding this comment.
랜덤한 index 각각 두 개를 뽑아서 서로 다른 값으로 맞춰주는 것보다는 조합으로 서로 다른 두 개의 index를 한 번에 선택하는 코드를 만들어보는건 어떨까용?
There was a problem hiding this comment.
Fisher-Yates 알고리즘 써서 배열을 섞어서 임의의 두 개의 인덱스 추출하도록 반영했습니다 :) 좋은 의견 감사합니다!
|
빌드를 성공했습니다! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🖥️ Preview
close #167
✏️ 한 일
❗️ 발생한 이슈 (해결 방안)
두 카드의 색상이 겹치지 않도록 하기 위해서, 만약 동일한 색이 나올 경우 동일한 색이 나오지 않을 때까지 오른쪽 카드를 랜덤으로 계속 돌려주도록 구현했습니다.
❓ 논의가 필요한 사항