Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] 메인 페이지 오류 수정 #141

Merged
merged 3 commits into from
Aug 13, 2024
Merged

[Fix] 메인 페이지 오류 수정 #141

merged 3 commits into from
Aug 13, 2024

Conversation

jhj2713
Copy link
Member

@jhj2713 jhj2713 commented Aug 13, 2024

🖥️ Preview

close #140

✏️ 한 일

  • 오류 발생 시 나오는 ErrorElement에서 navigate가 동작 안 하는 오류 수정
  • 추천인 property명 수정
  • useFetch 시 isError, isSuccess 초기화 로직 추가

❗️ 발생한 이슈 (해결 방안)

오류 발생 시 나오는 ErrorElement에서 navigate가 동작 안 하는 �문제가 있었습니다. 오류가 발생하는 경우 렌더링이 회복되지 못해서 navigate가 되지 않는 것으로 파악해, 돌아가기를 클릭하는 경우 아예 페이지 새로고침을 하도록 구현했습니다.

❓ 논의가 필요한 사항

@jhj2713 jhj2713 added the fix 버그가 발생 label Aug 13, 2024
@jhj2713 jhj2713 requested a review from sooyeoniya August 13, 2024 01:37
@jhj2713 jhj2713 self-assigned this Aug 13, 2024
@github-actions GitHub Actions
Copy link

빌드를 성공했습니다! 🎉

sooyeoniya
sooyeoniya approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@sooyeoniya sooyeoniya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

referralId 다시봐도 웃기네여 ㅋㅋㅋ

@jhj2713 jhj2713 merged commit 0542086 into dev Aug 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sooyeoniya sooyeoniya sooyeoniya approved these changes

Assignees

@jhj2713 jhj2713

Labels
fix 버그가 발생
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

메인 페이지 동작 오류 수정
2 participants
@jhj2713 @sooyeoniya