[Feat] 어드민 - API 연동 #139
Merged
[Feat] 어드민 - API 연동 #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
빌드를 성공했습니다! 🎉 |
sooyeoniya
approved these changes
Aug 12, 2024
admin/src/pages/Lottery/index.tsx
Outdated
Comment on lines
94
to
102
| <Button buttonSize="sm" onClick={() => navigate("/lottery/participant-list")}> | ||
| 참여자 리스트 보러가기 | ||
| </Button> | ||
| <Button | ||
| buttonSize="sm" | ||
| onClick={() => | ||
| navigate("/lottery/winner-list", { | ||
| state: { id: lottery.lotteryEventId }, | ||
| }) | ||
| } | ||
| > | ||
| <Button buttonSize="sm" onClick={() => navigate("/lottery/winner")}> | ||
| 당첨자 추첨하기 | ||
| </Button> | ||
| <Button buttonSize="sm" onClick={() => navigate("/lottery/winner-list")}> | ||
| 당첨자 보러가기 | ||
| </Button> |
There was a problem hiding this comment.
여기 공통 로직 분리하는 건 너무 사치일까용..?
const buttons = [
{ path: "/lottery/participant-list", label: "참여자 리스트 보러가기" },
{ path: "/lottery/winner", label: "당첨자 추첨하기" },
{ path: "/lottery/winner-list", label: "당첨자 보러가기" },
];
....
{buttons.map((button, idx) => (
<Button
key={idx}
buttonSize="sm"
onClick={() => navigate({button.path})}
>
{button.label}
</Button>
))}There was a problem hiding this comment.
흠 개인적으로는 Button 만으로 충분히 공통 로직을 묶어준 느낌이라서 buttons 배열로까지는 안 묶어줘두 될 것 같아요! 오히려 코드가 더 길어지기도 하구용,,,
Comment on lines
+1
to
+15
| export function getDateDifference(startDate: string, endDate: string) { | ||
| const dateRegex = /^\d{4}-\d{2}-\d{2}$/; | ||
|
|
||
| if (!startDate || !endDate || !startDate.match(dateRegex) || !endDate.match(dateRegex)) { | ||
| return ""; | ||
| } | ||
|
|
||
| const start = new Date(startDate); | ||
| const end = new Date(endDate); | ||
|
|
||
| const differenceInTime = end.getTime() - start.getTime(); | ||
| const differenceInDays = Math.ceil(differenceInTime / (1000 * 3600 * 24)); | ||
|
|
||
| return `${differenceInDays}일`; | ||
| } |
There was a problem hiding this comment.
이런식으로 시간 차이 구하는 로직 따로 빼서 사용하는 것도 좋은 방식인 것 같아용!
|
빌드를 성공했습니다! 🎉 |
|
빌드를 성공했습니다! 🎉 |
|
빌드를 성공했습니다! 🎉 |
|
빌드를 성공했습니다! 🎉 |
|
빌드를 성공했습니다! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🖥️ Preview
close #137
✏️ 한 일
❗️ 발생한 이슈 (해결 방안)
실제 API 연동은 아니고 명세서 기반으로 mock Promise 만들어서 연동해뒀습니다. 추후 API 완성되는대로 연결 테스트 해보겠습니다.
❓ 논의가 필요한 사항