[feat, refactor] mock 서버와 통신 관련 구체화 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lybell-art
approved these changes
Aug 12, 2024
Comment on lines
+22
to
+34
| useEffect(() => { | ||
| fetchServer(`/api/v1/draw/${EVENT_DRAW_ID}`) | ||
| .then((res) => { | ||
| console.log(res); | ||
| /* | ||
| * 사용자가 참여한 이벤트 날짜 문자열이 들어간 가변적 길이의 리스트를 서버로부터 받아올 예정. 그런데 그 문자열의 형식을 아직 모른다.. | ||
| */ | ||
| setJoinedList([0, 1, 1, 0, -1]); | ||
| }) | ||
| .catch((e) => { | ||
| console.log(e); | ||
| }); | ||
| }, []); |
There was a problem hiding this comment.
웬만해서는 useQuery와 Suspense를 사용해서 초기 데이터 페칭을 하시기 바랍니다.
Comment on lines
+46
to
+49
| if (getEventDateState(currentServerTime, eventDate) === "active") { | ||
| setIsJoined(true); | ||
| } | ||
| }, [currentServerTime, eventDate]); |
There was a problem hiding this comment.
현재 서버시간이 이벤트의 시점과 일치한다면 (이벤트가 진행중이라면) isjoined를 true로 바꾸는데, 그게 또 로그인해서 추첨이벤트에 참여를 성공해도 true가 되네요?
isjoined라는 상태가 알 수 없는 것 같습니다. 자세히 설명해 주시겠어요?
Comment on lines
+46
to
+49
| if (getEventDateState(currentServerTime, eventDate) === "active") { | ||
| setIsJoined(true); | ||
| } | ||
| }, [currentServerTime, eventDate]); |
There was a problem hiding this comment.
추가로 웬만해선 비동기이거나 불가피한 경우가 아니고서야 useEffect로 state를 갱신하는 건 자제하는 게 좋습니다.
파생된 상태는 그냥 바로 렌더링할 때마다 계산하면 됩니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관 이슈