-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] 사용자 정보등록 모달 구현 #70
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[refactor] Auth Modal이 더 이상 고정된 width/height값을 가지지 않고 페이지 자식의 height값을 갖도록 수정 [comment] 디자이너에 대한 분노 표출
…someOrange-FE into feature/17-auth
[design] 타이틀 텍스트 반응형으로 수정 [fix] 모달이 띄워질 때 타이틀 텍스트가 표시되는 버그 수정
Closed
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관 이슈
📝 작업 내용
AuthModal
컴포넌트입니다. 이 모달이 닫히고 사용자가 정보등록을 완료했을 때 실행시킬 콜백은 onComplete props로 넘겨주면 됩니다.💬 리뷰 요구사항
현재는 사용자가 정보등록을 완료하면 localStorage로 토큰은 저장하지만, 별도의 상태관리는 하지 않고 있습니다.
저희가 사용자 정보등록 완료했을 때 상단 헤더의 정보등록 렌더링을 바꿔야 하며, 그러기 위해서는 어딘가의 전역 상태관리 라이브러리에 사용자의 이름 정보를 넘겨주어야 합니다.
그걸 서버측에서 어떻게 받아오는 게 좋으려나요...