[feat] api 주소 수정, getDayDifference 함수 정의 #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lybell-art
approved these changes
Aug 16, 2024
Comment on lines
44
to
46
| .catch((e) => { | ||
| console.log(e); | ||
| }); |
There was a problem hiding this comment.
만약 에러가 났다면, setJoinedList를 [0,0,0,0,0] 같은걸로 설정해서 서버 오류시에도 동작은 하게 만드는 게 좋을 겁니다.
|
|
||
| export default function joinEvent(index) { | ||
| const isLogin = userStore.getState().isLogin; | ||
| const eventDate = EVENT_START_DATE.getTime() + index * 24 * 60 * 60 * 1000; |
There was a problem hiding this comment.
은근 24 * 60 * 60 * 1000 이라는 매직넘버가 저희 코드 지속적으로 쓰이는 것 같습니다.
하나의 상수로 뭉쳐야 할 것 같습니다...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관 이슈
📝 작업 내용