Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] 자잘한 오류 수정 및 카드게임 스켈레톤 UI 추가 #101

Merged
merged 5 commits into from
Aug 16, 2024
Merged

[fix] 자잘한 오류 수정 및 카드게임 스켈레톤 UI 추가 #101

merged 5 commits into from
Aug 16, 2024

Conversation

lybell-art
Copy link
Collaborator

#️⃣ 연관 이슈

없음

📝 작업 내용

fetchServer는 이제 에러 결과를 json으로 파싱하지 않습니다.
4xx/5xx대 에러 뜰 때 html으로 오는 경우가 많아서 그렇습니다.

선착순 페이지에 스켈레톤 ui를 추가했습니다.
추가로 이상한 에러가 떴을 때에도 오프라인 폴백 카드 뒤집기 인터랙션으로 전환하도록 했습니다.
카드게임 자체에서 에러 나면... 개발자한테 전화하세요

@lybell-art lybell-art added the fix 버그 및 오류 수정 label Aug 16, 2024
@lybell-art lybell-art requested a review from darkdulgi August 16, 2024 04:15
@lybell-art lybell-art self-assigned this Aug 16, 2024
darkdulgi
darkdulgi approved these changes Aug 16, 2024
View reviewed changes
Copy link
Collaborator

@darkdulgi darkdulgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@darkdulgi darkdulgi merged commit 339c4a9 into dev Aug 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkdulgi darkdulgi darkdulgi approved these changes

Assignees

@lybell-art lybell-art

Labels
fix 버그 및 오류 수정
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lybell-art @darkdulgi