fix : DB 병목 개선 - FindingGameWinner에 데이터 넣을 때 NativeQuery사용 (CC-176) #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
putdata
changed the title
넴 |
j2noo
approved these changes
Aug 22, 2024
| if (completed > 0) { | ||
| log.info("선착순 인원 스케쥴링 처리 완료 - {} 건", completed); | ||
| } | ||
| } | ||
|
|
||
| @Transactional | ||
| protected void insertWinner(Integer gameId, String phone) { |
There was a problem hiding this comment.
https://mangkyu.tistory.com/269
트랜잭션이 중첩되었을때, 내부 트랜잭션 단위로 커밋을 하고싶은거라면 REQUIRES_NEW인가요? 궁금!!
There was a problem hiding this comment.
외부트랜잭션 insertWinnerToDatabaseScheduler 에서 내부 트랜잭션이 실패하면 지금까지 커밋된 내용은 반영되고 외부트랜잭션은 그냥 종료시키고 싶었습니다. REQUIRES_NEW를 통해서 새로운 트랜잭션을 만들어야할 것 같아요.
j2noo
approved these changes
Aug 22, 2024
| @@ -37,17 +37,21 @@ public void insertWinnerToDatabaseScheduler() { | |||
| if (realWinner == null) break; | |||
| Integer gameId = realWinner.getGameId(); | |||
| String phone = realWinner.getPhone(); | |||
| insertWinner(gameId, phone); | |||
| try { | |||
There was a problem hiding this comment.
그냥 Exception을 던지고 다른 서비스에서 받는? 그런 로직? (저도잘모름) 도 생각하면 코드 깔끔할 것 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 작업내용
실제 조회 대신 프록시 객체 사용💬 침고사항
📖 레퍼런스