feat : 선착순 등록 시 병목을 막기 위한 스케쥴러 구현 (CC-176) #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
putdata
commented
Aug 22, 2024
| import com.fasterxml.jackson.databind.annotation.JsonDeserialize; | ||
| import com.fasterxml.jackson.databind.annotation.JsonSerialize; | ||
| import com.fasterxml.jackson.datatype.jsr310.deser.LocalDateTimeDeserializer; | ||
| import com.fasterxml.jackson.datatype.jsr310.ser.LocalDateTimeSerializer; |
There was a problem hiding this comment.
리팩토링하면서 불필요한 임포트 삭제 필요
j2noo
approved these changes
Aug 22, 2024
| int completed = 0; | ||
| List<FindingGameWinner> winners = new ArrayList<>(); | ||
| for (int i = 0; i < TRANSACTION_COUNT; i++) { | ||
| FindingGameRealWinner realWinner = findingGameRedisRepository.getFrontRealWinner(); |
There was a problem hiding this comment.
여기서 바로 popRealWinner 하지않고 get 먼저 하는 이유가 몬가요
There was a problem hiding this comment.
중간에 에러뜨면 redis Pop된게 트랜잭션 유지가 안되서 어느정도 최대한 보존할 수 있게 했습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 작업내용
💬 침고사항
📖 레퍼런스