fix : 레이싱 게임 추첨 당첨자 수 가져오기 및 NullPointerError 수정 (CC-175) #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j2noo
approved these changes
Aug 21, 2024
| } | ||
| // N명 중에서 한 명을 선택한 후, 그 사람을 가중치 / 전체 가중치 확률로 당첨자로 만든다. 이를 당첨인원수만큼 반복 | ||
| int drawNumber = Math.min(315, participants.size()), ranking = 1; // TODO: 315 Global 변수화 | ||
| RacingGameInfoResponseDto racingGameInfo = racingGameInfoService.getRacingGameInfo(); | ||
| int drawNumber = Math.min(racingGameInfo.numberOfWinners(), participants.size()), ranking = 1; |
There was a problem hiding this comment.
int drawNumber = ~ ;
int ranking = 1;
이렇게 분리해서 선언하면 어떤가요
j2noo
pushed a commit
that referenced
this pull request
Aug 21, 2024
* fix : 레이싱 게임 추첨 당첨자 수 가져오기 및 NullPointerError 수정 (CC-175) * style : 변수 선언 컨벤션 (CC-175)
j2noo
added a commit
that referenced
this pull request
Aug 21, 2024
) * test : 힌트 생성 api 테스트코드 작성(CC-173) * test : 숨은캐스퍼찾기 사용자가 정답 입력하는 로직 테스트코드 작성(CC-173) * test : 어드민이 숨캐찾 게임 기간을 설정하는 테스트코드(CC-173) * test : 어드민이 숨캐찾 게임 날짜별 정답 정보를 설정하는 테스트코드(CC-173) * test : 어드민이 레이싱게임 당첨자를 추첨하는 테스트코드(CC-173) * style : 미사용 코드 제거 (CC-173) * fix : 레이싱 게임 추첨 당첨자 수 가져오기 및 NullPointerError 수정 (CC-175) (#43) * fix : 레이싱 게임 추첨 당첨자 수 가져오기 및 NullPointerError 수정 (CC-175) * style : 변수 선언 컨벤션 (CC-175) * fix : 서비스 순환 참조 수정 및 테스트코드 작성 (CC-173) --------- Co-authored-by: ikjunoh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 작업내용
💬 침고사항
📖 레퍼런스