Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMake] Add possibility to remove auto installing of ressource files #5230

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bakpaul
Copy link
Contributor

@bakpaul bakpaul commented Jan 20, 2025

The goal of this PR is to be able to use the macro sofa_create_package_with_targets while still managing the resources ourself. Currently the macro is autodetecting folders examples and scenes and automatically installing them. But if we want to filter those files for instance, it is not possible. Now it is.
--> the previous behavior is still the default one, the resources will not be automatically installed if the option NO_AUTO_RESOURCES_INSTALL is passed.

This is needed for the PR in ModelOrderReduction on which this PR depends.

[ci-depends-on https://github.com/SofaDefrost/ModelOrderReduction/pull/152]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@bakpaul bakpaul added pr: status to review To notify reviewers to review this pull-request pr: new feature Implement a new feature labels Jan 20, 2025
bakpaul added a commit to bakpaul/ModelOrderReduction that referenced this pull request Jan 20, 2025
…les files by hand and not install debug files
@fredroy
Copy link
Contributor

fredroy commented Jan 21, 2025

is this not a duplicate of

option(SOFA_INSTALL_RESOURCES_FILES "Copy resources files (etc/, share/, examples/, tools/sofa-launcher/) when installing" ON)

EDIT: actually no, your PR is targeted towards plugins/targets
but a little more description would be helpful 🫢

@bakpaul
Copy link
Contributor Author

bakpaul commented Jan 21, 2025

I've added some details, thank you for your feedback !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new feature Implement a new feature pr: status to review To notify reviewers to review this pull-request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants