[All] Refactor create/cancreate in ObjectFactory #5195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damienmarchal
added
pr: status wip
|
@damienmarchal in case you missed them, there are some compilation errors |
alxbilger
reviewed
Jan 9, 2025
| @@ -260,13 +290,51 @@ class ObjectCreator : public ObjectFactory::Creator | |||
| public: | |||
| bool canCreate(objectmodel::BaseContext* context, objectmodel::BaseObjectDescription* arg) override | |||
| { | |||
| RealObject* instance = nullptr; | |||
| return RealObject::canCreate(instance, context, arg); | |||
| if constexpr( HasCanCreateMethod<RealObject>::value ) | |||
There was a problem hiding this comment.
you can now use a concept. I would look like:
if constexpr (requires { RealObject::canCreate; })
|
Thank @alxbilger for pointing the compilation error. |
damienmarchal
commented
Jan 22, 2025
| @@ -53,6 +53,33 @@ namespace sofa::core | |||
|
|
|||
| class ObjectRegistrationData; | |||
|
|
|||
| template<class T> | |||
There was a problem hiding this comment.
wait for concepts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This topic has been addressed in a lot of previous postpone PR.
In this one I propose an approach which has a compatibility layer to be not breaking.
The important code is in ObjectFactory.h
All the rest is just there to point where are the "yet to fix" components.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if