Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Collision] ADD optional viscous friction at sliding contact points #4991

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

aleblanc30
Copy link

Add a parameter "drag" to the collision response. When two objects slip past each other, a force of magnitude -drag*relative_velocity is applied to the contact points.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: status to review To notify reviewers to review this pull-request pr: new feature Implement a new feature labels Sep 22, 2024
@fredroy fredroy added the pr: breaking Change possibly inducing a compilation error label Sep 22, 2024
@hugtalbot
Copy link
Contributor

Hi @aleblanc30
A very nice PR for a first PR! Thanks a lot reviews have been shared to you:

MOR plugin need to be fixed (we will take care of it) and take reviews into account regarding the object registration.

@aleblanc30
Copy link
Author

Thank you @hugtalbot, I'm working on it :-)

@bakpaul bakpaul added this to the v24.12 milestone Dec 2, 2024
@hugtalbot hugtalbot modified the milestones: v24.12, v25.06 Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: breaking Change possibly inducing a compilation error pr: new feature Implement a new feature pr: status to review To notify reviewers to review this pull-request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants