Update review comments

Analysis/DataStorageProjects/Delfin/ResourceModel/ResourceModel.md

@@ -32,7 +32,7 @@ Following are the resource models derived from analyzing some the leading storag
 
 ### Resource Model implementation diagram
 
-![Resource Model Diagram](ResourceModel.jpg)
+![Resource Model Diagram](ResourceModel.png)
 
 ### Controller
 
@@ -43,10 +43,10 @@ native_controller_id | string | id of the controller in device
 name | string | name of the controller
 status | enum | running status of the controller (normal, offline, unknown)
 location | string | node/rack/slot/module location
+storage_id | string | delfin id of the associated storage
 soft_version | string | software version/firmware version
 cpu_info | string | processor information
-memory_size | string | cache memory size
-storage_id | string | delfin id of the associated storage
+memory_size | string | cache memory size in bytes
 
 ### Port
 
@@ -55,21 +55,21 @@ Attributes | Type | Description/enum
 id | string | UUID of the port
 native_port_id | string | id of the port in actual device
 name | string | name of the port
-location | string | position of the port (controller, slot, port number)
-connection_status | enum | connection status (connected, disconnected, unknown)
-health_status | enum | health status of the port (normal,abnormal,unknown)
 type | enum | port type (FC,ISCSI,FICON,FCoE,ETH,SAS,OTHER,IB)
 logical_type | enum | front_end_service, back_end_service, service, management,internal,maintenance,management_service,maintenance_service,interconnect, other
-speed | int | running (current) speed of the port
-max_speed | int | maximum supported  speed of the port
+connection_status | enum | connection status (connected, disconnected, unknown)
+health_status | enum | health status of the port (normal,abnormal,unknown)
+location | string | position of the port (controller, slot, port number)
 storage_id | string | delfin id of the associated storage
 native_parent_id | string | id of the controller where this port is associated
-wwn | string | wwwn for a FC/FCoE port
+speed | int | running (current) speed of the port
+max_speed | int | maximum supported  speed of the port
+wwn | string | wwn for a FC/FCoE port
 mac_address | string | mac_address of a Ethernet port
 ipv4 | string | ipv4 of an Ethernet port
-ipv4_mask | string | ipv4_mask of an Ethernet port
+ipv4_mask | string | ipv4_mask of an Ethernet port, gateway
 ipv6 | string | ipv6 of an Ethernet port
-ipv6_mask | string | ipv6_mask of an Ethernet port
+ipv6_mask | string | ipv6_mask of an Ethernet port, gateway
 
 ### Disk
 
@@ -78,19 +78,19 @@ Attributes | Type | Description
 id | string | UUID of the disk
 native_disk_id | string | original ID of the disk
 name | string | Name   of the device
+physical_type | enum | physical type [sata, sas, ssd,nl-sas, unknown]
+logical_type | enum | logical type [free, member, hotspare, cache]
+status | enum | status of the disk [normal, offline, abnormal]
+location | string | location
+storage_id | string | delfin storage ID this disk belong
+native_disk_group_id | string | delfin disk group ID
 serial_number | string | serial number of the disk
 manufacturer | string | manufacturer of the disk
 model | string | model of the disk
 firmware | string | firmware of the disk
 speed | long | rotational speed (HDD)
 capacity | double | capacity in bytes
-status | enum | status of the disk [normal, offline, abnormal]
-physical_type | enum | physical type [sata, sas, ssd,nl-sas, unknown]
-logical_type | enum | logical type [free, member, hotspare, cache]
 health_score | double | health score
-native_disk_group_id | string | delfin disk group ID
-storage_id | string | delfin storage ID this disk belong
-location | string | location
 
 ### Disk Group
 
@@ -100,56 +100,44 @@ id | string | UUID of the disk group
 native_disk_group_id | string | original ID of the disk group
 name | string | name of the disk group
 status | enum | status [normal, offline, abnormal]
+storage_id | string | delfin storage ID this disk group belong
+native_storage_pool_id | string | delfin storage pool ID this disk group belong
 total_capacity | double | total capacity of disk group
 spare_capacity | double | spare capacity of disk group
-native_storage_pool_id | string | delfin storage pool ID this disk group belong
-storage_id | string | delfin storage ID this disk group belong
 
 ### Storage Pool
 
 Attributes | Type | Description
 -- | -- | --
 id | string | UUID of the storage pool
-name | string | name of the storage pool
-storage_id | string | delfin storage ID this storage pool belong
 native_storage_pool_id | string | origin pool id from storage
+name | string | name of the storage pool
 description | string | description for the storage pool
-status | string | status of the storage pool
 storage_type | string | storage type of the storage pool
+status | string | status of the storage pool
+storage_id | string | delfin storage ID this storage pool belong
 total_capacity | Integer | total capacity of the storage pool
 used_capacity | Integer | used capacity of the storage pool
 free_capacity | Integer | free capacity of the storage pool
 subscribed_capacity | Integer | subscribed capacity of the storage pool
-compression_enabled | Boolean | whether compression enabled for the storage pool
-compression_rate | Integer | compression rate of the storage pool
-deduplication_enabled | Boolean | whether deduplication enabled for the storage pool
-deduplication_rate | Integer | deduplication rate of the storage pool
-data_reduction | Boolean | whether data reduction enabled for the storage pool
-data_reduction_rate | Integer | data reduction rate of the storage pool
-data_reduction_size_saved | Integer | data reduction size saved of the storage pool
-tier | List[object] | tier of the storage pool
+compressed | Boolean | whether compression enabled for the storage pool
+deduplicated | Boolean | whether deduplication enabled for the storage pool
 
 ### Volumes
 
 Attributes | Type | Description
 -- | -- | --
 id | string | UUID of the volume
+native_volume_id | string | original id of the volume
 name | string | name of the volume
-storage_id | string | delfin ID of storage this volume belong
-native_storage_pool_id | string | original id of pool this volume belong
 description | string | description of the volume
+type | string | type of the volume
 status | string | status of the volume
-native_volume_id | string | original id of the volume
+storage_id | string | delfin ID of storage this volume belong
+native_storage_pool_id | string | original id of pool this volume belong
 wwn | string | wwn of the volume
-type | string | type of the volume
 total_capacity | Integer | total capacity of the volume
 used_capacity | Integer | used capacity of the volume
 free_capacity | Integer | free capacity of the volume
-compression_enabled | Boolean | whether compression enabled for the volume
-compression_rate | Integer | compression rate of the volume
-deduplication_enabled | Boolean | whether deduplication enabled for the volume
-deduplication_rate | Integer | deduplication rate of the volume
-data_reduction | Boolean | whether data reduction enabled for the volume
-data_reduction_rate | Integer | data reduction rate of the volume
-data_reduction_size_saved | Integer | data reduction size saved for the volume
-pool-tier | List[object] | pool tier of this volume
+compressed | Boolean | whether compression enabled for the volume
+deduplicated | Boolean | whether deduplication enabled for the volume