Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attach has been replaced by installHandlers #299

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ echo.on('connection', function(conn) {
});

const server = http.createServer();
echo.attach(server);
echo.installHandlers(server);
server.listen(9999, '0.0.0.0');
```

Expand Down Expand Up @@ -181,7 +181,7 @@ Once you have create `Server` instance you can hook it to the

```javascript
var http_server = http.createServer();
sockjs_server.attach(http_server);
sockjs_server.installHandlers(http_server);
http_server.listen(...);
```

Expand All @@ -197,7 +197,7 @@ and emits following event:
All http requests that don't go under the path selected by `prefix`
will remain unanswered and will be passed to previously registered
handlers. You must install your custom http handlers before calling
`attach`. You can remove the SockJS handler later with `detach`.
`installHandlers`. You can remove the SockJS handler later with `detach`.

## Connection instance

Expand Down