Add "no-transform" to the no_cache headers #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran into an issue running meteor which user sockjs. My site didn't work when running on Chrome iOS with Google's [Data Saver](https://developer.chrome.com/multidevice/data-compression) feature turned on. I [filed a bug](https://code.google.com/p/chromium/issues/detail?id=553828#) but the change above *seems* to work around the issue for now until they can fix it on their side.
|
I posted a small meteor sample here http://data-saver-issue.meteor.com If you use Chrome on iOS and turn on the Data Saver feature you'll see it doesn't work. If you manage to patch meteor with the fix above it will start working |
|
Nice find! |
brycekahle
added a commit
that referenced
this pull request
Nov 10, 2015
Add "no-transform" to the no_cache headers
|
So, ... AFAICT this patch can be reverted and probably should be if #190 is fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue running meteor which user sockjs. My site didn't work when running on Chrome iOS with Google's Data Saver feature turned on.
I filed a bug but the change above seems to work around the issue for now until they can fix it on their side.