Add maximum retries to polling after network error. #472
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A possible solution to #440
I need that, as that infinite loop is giving a hard time to the load balancer when we have a couple of users having this issue.
What it does is that for every connection request, it stops retrying after 3 unsuccessful requests. It's the consumer's responsibility then to decide what to do (e.g. retry again?)
I'm not fully aware of the internals of this library, so I'm not too sure if this is fully safe to merge in, but it seems to cover the basic use case.