Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail if the key path is empty. #57

Merged
merged 1 commit into from
Jul 7, 2024
Merged

Fail if the key path is empty. #57

merged 1 commit into from
Jul 7, 2024

Conversation

ioquatix
Copy link
Member

@ioquatix ioquatix commented Jul 7, 2024

Fixes #56.

We could accept nil keys, but there is no way to reasonably format it, e.g. consider {nil => {nil => "foo"}} would format, hypothetically, as []=foo which would decode as {nil => ["foo"]}. I can't see any way to disambiguate the situation.

Types of Changes

  • Bug fix.

Contribution

@ioquatix ioquatix merged commit cc5501f into main Jul 7, 2024
36 checks passed
@ioquatix ioquatix deleted the nil-key-path branch July 7, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protocol::HTTP::URL.decode fails to decode =foo
1 participant