Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

as_json should ignore all arguments. Add default to_json. #54

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

ioquatix
Copy link
Member

@ioquatix ioquatix commented Apr 16, 2024

Follow up to #53.

def as_json(...) should accept and ignore all arguments.

We should add a default to_json -> as_json.to_json(...) too, otherwise, JSON.dump won't use it.

Types of Changes

  • Bug fix.

Contribution

@ioquatix ioquatix merged commit ac442ae into main Apr 16, 2024
32 of 43 checks passed
@ioquatix ioquatix deleted the as_json branch April 16, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant