Use `@callback` to track the state of the invocation. #52

ioquatix · 2024-04-09T06:41:37Z

While experimenting with streaming bodies, I found that in some cases, Completable could cause subsequent #read to fail. While we should probably fix #read too (handle nil body), this is probably the best solution.

Types of Changes

Bug fix.
Maintenance.

Contribution

I added tests for my changes.
I tested my changes locally.
I agree to the Developer's Certificate of Origin 1.1.

Setting `@body = nil` can cause other operations to fail.

Use @callback to track the state of the invocation.

dd71918

Setting `@body = nil` can cause other operations to fail.

ioquatix merged commit 476cced into main Apr 9, 2024
36 of 44 checks passed

ioquatix deleted the completable-read branch April 9, 2024 06:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use `@callback` to track the state of the invocation. #52

Use `@callback` to track the state of the invocation. #52

ioquatix commented Apr 9, 2024 •

edited

Loading

Use @callback to track the state of the invocation. #52

Use @callback to track the state of the invocation. #52

Conversation

ioquatix commented Apr 9, 2024 • edited Loading

Types of Changes

Contribution

Use `@callback` to track the state of the invocation. #52

Use `@callback` to track the state of the invocation. #52

ioquatix commented Apr 9, 2024 •

edited

Loading