Skip empty key/value pairs. (#59)

socketry · Jul 7, 2024 · fe31f2e · fe31f2e
1 parent cbb8ae2
commit fe31f2e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/lib/protocol/http/url.rb b/lib/protocol/http/url.rb
@@ -58,6 +58,8 @@ def self.encode(value, prefix = nil)
 			# 	@parameter value [String] The unescaped key.
 			def self.scan(string)
 				string.split('&') do |assignment|
+					next if assignment.empty?
+
 					key, value = assignment.split('=', 2)
 
 					yield unescape(key), value.nil? ? value : unescape(value)

diff --git a/test/protocol/http/url.rb b/test/protocol/http/url.rb
@@ -76,6 +76,11 @@
 				Protocol::HTTP::URL.decode("=foo")
 			end.to raise_exception(ArgumentError, message: be =~ /Invalid key/)
 		end
+
+		it "fails with empty pairs" do
+			expect(Protocol::HTTP::URL.decode("a=1&&b=2")).to be == {"a" => "1", "b" => "2"}
+			expect(Protocol::HTTP::URL.decode("a&&b")).to be == {"a" => nil, "b" => nil}
+		end
 	end
 
 	with '.unescape' do