added codefresh template #40
Conversation
| stages: | ||
| - "prepare" | ||
| - "verify" | ||
| - "deploy" |
There was a problem hiding this comment.
this stage is declared but not used below, I suggest to remove it
| revision: "${{CF_REVISION}}" | ||
| stage: "prepare" | ||
|
|
||
| run_unit_tests: |
There was a problem hiding this comment.
we don't need to run unit tests for these examples, let's focus solely on the steps required for getting snyk tests to work (also, the mvn invocation does not run tests, but calls package - which compiles the app)
|
|
||
| version: "1.0" | ||
| # Stages can help you organize your steps in stages | ||
| stages: |
There was a problem hiding this comment.
consider setting up a "security" stage and showcase the 4 snyk products in a task each, so code, open source, container+image, iac
| stage: verify | ||
| image: 'snyk/snyk-cli:maven-3.6.3_java11' | ||
| commands: | ||
| - snyk monitor |
There was a problem hiding this comment.
this command needs a token & authentication - where is it handled?
| image: 'maven:3.5.2-jdk-8-alpine' | ||
| commands: | ||
| - mvn -Dmaven.repo.local=/codefresh/volume/m2_repository package | ||
| build_app_image: |
There was a problem hiding this comment.
after the docker image is built, it is not used in the below stages
- either we skip this step
- or we pass the built image name to the
security.containerstep, for example (security stage to be done)
| @@ -0,0 +1,42 @@ | |||
| # More examples of Codefresh YAML can be found at | |||
| # https://codefresh.io/docs/docs/yaml-examples/examples/ | |||
There was a problem hiding this comment.
At the moment, no report artefacts are generated. I suggest we go without first and setup a GH issue on this repo to showcase static HTML reports like these https://codefresh.io/docs/docs/testing/test-reports/ (via snyk-to-html)
No description provided.