-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added trigger for Google Cloud Build #36
base: master
Are you sure you want to change the base?
Changes from 5 commits
7fdc90e
d7d6150
9c49aa6
e15827f
588e71d
533c214
42a5dbf
7285797
c5d7744
1160087
8efdbe2
43720a6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
@@ -0,0 +1,42 @@ | ||||
# You can find the Snyk Official CLI container images here: https://github.com/snyk/cli#snyk-cli-in-a-docker-image | ||||
steps: | ||||
- name: 'snyk/snyk-cli:npm' | ||||
args: | ||||
- '-c' | ||||
- |- | ||||
snyk config set api=${_SNYK_TOKEN} | ||||
snyk test --json-file-output=results-open-source.html || true | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. On the file output: this line (and L16, L24, L32) do not produce the expected output. Please add a snyk-cicd-integration-examples/AzurePipelines/AzurePipelines-npm-generic-html.yml Line 42 in c21e80b
On the return code: Unfortunately GCB does not support something like
Which shows the developer our approach for exiting with 0 by default, but showing them how to enable the security gate again. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've checked in the wrong codes previously hence the confusion. Changes made. |
||||
id: Snyk Open Source test | ||||
entrypoint: bash | ||||
- name: 'snyk/snyk-cli:npm' | ||||
args: | ||||
- '-c' | ||||
- |- | ||||
snyk config set api=${_SNYK_TOKEN} | ||||
snyk code test --sarif-file-output=results-code.html || true | ||||
id: Snyk Code test | ||||
entrypoint: bash | ||||
- name: 'snyk/snyk-cli:npm' | ||||
args: | ||||
- '-c' | ||||
- |- | ||||
snyk config set api=${_SNYK_TOKEN} | ||||
snyk iac test <TERRAFORM FILE> --json-file-output=results-iac.html || true | ||||
id: Snyk IaC test | ||||
entrypoint: bash | ||||
- name: 'snyk/snyk-cli:npm' | ||||
args: | ||||
- '-c' | ||||
- |- | ||||
snyk config set api=${_SNYK_TOKEN} | ||||
snyk container test <CONTAINER_IMAGE> --json-file-output=results-container.html || true | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please add the |
||||
id: Snyk Container test | ||||
entrypoint: bash | ||||
artifacts: | ||||
objects: | ||||
location: 'gs://<STORE_NAME>/scan_output' | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not familiar with GCB here, but is There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. output folder There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's ok, I've removed this output folder on Google Cloud Storage. I will just store all in the root directory of the storage. All good. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. STORE_NAME seems to be a required variable. Please explain the requirement on the top of file as well. |
||||
paths: | ||||
- results-open-source.html | ||||
- results-code.html | ||||
- results-iac.html | ||||
- results-container.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a line or two of comments on the top of the file similar to other recently updated file to explain what is being shown in the file.