Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MINOR] Use default DriverLauncher #1205

Merged
merged 2 commits into from
Jul 17, 2017
Merged

[MINOR] Use default DriverLauncher #1205

merged 2 commits into from
Jul 17, 2017

Conversation

wynot12
Copy link
Contributor

@wynot12 wynot12 commented Jul 14, 2017

#1081 has introduced a custom version of DriverLauncher. But I found that we can simply use the REEF's default DriverLauncher by injecting custom configuration.

So this PR removes the custom DriverLauncher.

@wynot12 wynot12 requested a review from JunhoeKim July 14, 2017 18:01
@wynot12
Copy link
Contributor Author

wynot12 commented Jul 14, 2017

@JunhoeKim please take a look :)

@wynot12 wynot12 mentioned this pull request Jul 14, 2017
Merged
@JunhoeKim
Copy link
Contributor

!rebuild

@JunhoeKim JunhoeKim merged commit 6841f90 into master Jul 17, 2017
@JunhoeKim JunhoeKim deleted the minor-driver-launcher branch July 17, 2017 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JunhoeKim JunhoeKim JunhoeKim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wynot12 @JunhoeKim