Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1227362 Re-enable Package Related Tests #97

Merged
merged 1 commit into from
Apr 17, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 2 additions & 16 deletions src/test/scala/com/snowflake/snowpark/UDFInternalSuite.scala
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,10 @@ class UDFInternalSuite extends TestData {
super.afterAll
}

// todo: re-enable in SNOW-1227362
// The new Geometry data type introduced in the release 1.12.0.
// The package suites use the latest Snowpark package on the server side,
// which doesn't have Geometry type, then, all package suites will fail
// before the server side release. So we have to temporarily disable those test suite
// until Snowpark 1.12.0 release.
ignore("Test temp udf not failing back to upload jar", JavaStoredProcExclude) {
test("Test temp udf not failing back to upload jar", JavaStoredProcExclude) {
val newSession = Session.builder.configFile(defaultProfile).create
val mockSession = spy(newSession)
TestUtils.addDepsToClassPath(mockSession, None)
TestUtils.addDepsToClassPath(mockSession, None, usePackages = true)
val path = UDFClassPath.getPathForClass(classOf[com.snowflake.snowpark.Session]).get

val doubleUDF = mockSession.udf.registerTemporary((x: Int) => x + x)
Expand Down Expand Up @@ -185,13 +179,6 @@ class UDFInternalSuite extends TestData {
}
}

// todo: re-enable in SNOW-1227362
// The new Geometry data type introduced in the release 1.12.0.
// The package suites use the latest Snowpark package on the server side,
// which doesn't have Geometry type, then, all package suites will fail
// before the server side release. So we have to temporarily disable those test suite
// until Snowpark 1.12.0 release.
/*
@UDFPackageTest
class PackageUDFSuite extends UDFSuite {
override def beforeAll: Unit = {
Expand Down Expand Up @@ -227,4 +214,3 @@ class PackageUDTFSuite extends UDTFSuite {
super.afterAll()
}
}
*/
Loading