Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCT-10981 Add an overload method for functions.max, functions.min and functions.mean #94

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

sfc-gh-fgonzalezmendez
Copy link
Collaborator

@sfc-gh-fgonzalezmendez sfc-gh-fgonzalezmendez commented Apr 2, 2024

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SCT-10981

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    It adds an overload method that receives a column name as parameter for the following functions:

    • com.snowflake.snowpark.functions.max
    • com.snowflake.snowpark.functions.min
    • com.snowflake.snowpark.functions.mean

Pre-review checklist

(For Snowflake employees)

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@sfc-gh-fgonzalezmendez
Copy link
Collaborator Author

Hi @sfc-gh-bli 👋,

Could you take a look at this Pull Request, please?

Copy link
Collaborator

@sfc-gh-bli sfc-gh-bli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-fgonzalezmendez sfc-gh-fgonzalezmendez merged commit c01d321 into main Apr 10, 2024
17 checks passed
@sfc-gh-fgonzalezmendez sfc-gh-fgonzalezmendez deleted the SCT-10981 branch April 10, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants