Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCT-2668 Add appName method to SessionBuilder to register in query_tag. #85

Merged
merged 7 commits into from
Mar 4, 2024
Merged

SCT-2668 Add appName method to SessionBuilder to register in query_tag. #85

merged 7 commits into from
Mar 4, 2024

Conversation

sfc-gh-dchaconbarrantes
Copy link
Contributor

@sfc-gh-dchaconbarrantes sfc-gh-dchaconbarrantes commented Feb 21, 2024 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    This PR is intend to make easier to track Spark migrated workloads.

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    It assigns the query_tag with the app name after a new session is created.

Pre-review checklist

(For Snowflake employees)

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

sfc-gh-mvegaalvarez
sfc-gh-mvegaalvarez approved these changes Feb 21, 2024
View reviewed changes
Copy link

@sfc-gh-mvegaalvarez sfc-gh-mvegaalvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

sfc-gh-bli
sfc-gh-bli approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-bli sfc-gh-bli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-dchaconbarrantes sfc-gh-dchaconbarrantes merged commit e968927 into main Mar 4, 2024
16 checks passed
@sfc-gh-dchaconbarrantes sfc-gh-dchaconbarrantes deleted the SCT-2668 branch March 4, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jfreeberg sfc-gh-jfreeberg sfc-gh-jfreeberg left review comments

@sfc-gh-mvegaalvarez sfc-gh-mvegaalvarez sfc-gh-mvegaalvarez approved these changes

@sfc-gh-bli sfc-gh-bli sfc-gh-bli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-dchaconbarrantes @sfc-gh-bli @sfc-gh-jfreeberg @sfc-gh-mvegaalvarez