SNOW-966360 Support Explode Function #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-zli
reviewed
Nov 30, 2023
| // process explode function with literal values | ||
| private def callExplode(input: Column): DataFrame = { | ||
| import this.implicits._ | ||
| val dummyDF = Seq(1).toDF("a") |
There was a problem hiding this comment.
I don't understand here why we need to create a DF with dummy value and column names. This is not even in test.
There was a problem hiding this comment.
I want to reuse the DataFrame.join function since it supports explode function.
So I want to create an empty DataFrame, and then add input in this DataFrame via withColumn.
However, Snowpark doesn't support empty DataFrame, therefore I created a dummy DataFrame and remove the dummy column later.
sfc-gh-zli
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
explodefunctionDataFrame.select,DataFrame.joinandSession.tableFunction