Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-802269 Add ordering and size function for scala and java modules… #137

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

sfc-gh-gmahadevan
Copy link
Collaborator

… (#133)

  • add java and scala size and ordering functions

  • add scala unit test for ordering and size function

  • update comments and add example

  • add java test cases

  • fix comments


Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #SNOW-802269

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Add below missing functions in scala and java modules

API Description
functions.desc equivalent to Column.desc
functions.asc equivalent to Columns.asc
functions.size equivalent to array_size

Pre-review checklist

(For Snowflake employees)

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

…#133)

* add java and scala size and ordering functions

* add scala unit test for ordering and size function

* update comments and add example

* add java test cases

* fix comments

---------

Co-authored-by: sfc-gh-mrojas <[email protected]>
Copy link
Collaborator

@sfc-gh-bli sfc-gh-bli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-gmahadevan sfc-gh-gmahadevan merged commit d26eb08 into main Aug 7, 2024
15 checks passed
@sfc-gh-gmahadevan sfc-gh-gmahadevan deleted the SNOW-802269-func1-gm branch August 7, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants