Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-802269 Added regexp_extract,signum,substring_index,collect_list #135

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

sfc-gh-sjayabalan
Copy link
Collaborator

@sfc-gh-sjayabalan sfc-gh-sjayabalan commented Aug 5, 2024

  1. Added regexp_extract,signum,substring_index,collect_list to functions.scala .
  2. Added test cases for the same

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Replace this with a short description of how your code change solves the related issue.

Pre-review checklist

(For Snowflake employees)

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

1) Added regexp_extract,signum,substring_index,collect_list to functions.scala .
2) Added test cases for the same
@sfc-gh-sjayabalan sfc-gh-sjayabalan changed the title Added regexp_extract,signum,substring_index,collect_list Jira number - SNOW-802269 Added regexp_extract,signum,substring_index,collect_list Aug 8, 2024
Copy link
Collaborator

@sfc-gh-bli sfc-gh-bli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-bli sfc-gh-bli self-requested a review August 8, 2024 22:55
Copy link
Collaborator

@sfc-gh-bli sfc-gh-bli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the PR title to
SNOW-802269 Added regexp_extract,signum,substring_index,collect_list
It should start with the Jira number

@sfc-gh-mrojas sfc-gh-mrojas changed the title Jira number - SNOW-802269 Added regexp_extract,signum,substring_index,collect_list SNOW-802269 Added regexp_extract,signum,substring_index,collect_list Aug 9, 2024
@sfc-gh-sjayabalan
Copy link
Collaborator Author

Please change the PR title to SNOW-802269 Added regexp_extract,signum,substring_index,collect_list It should start with the Jira number

Modified the pr title.Please verify

Copy link
Collaborator

@sfc-gh-bli sfc-gh-bli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-bli sfc-gh-bli self-requested a review September 3, 2024 16:27
Copy link
Collaborator

@sfc-gh-bli sfc-gh-bli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change all versions @since x.xx.x in this PR to @since 1.15.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants