-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-802269 Added regexp_extract,signum,substring_index,collect_list #135
base: main
Are you sure you want to change the base?
Conversation
1) Added regexp_extract,signum,substring_index,collect_list to functions.scala . 2) Added test cases for the same
…tlist' of https://github.com/sfc-gh-sjayabalan/snowpark-java-scala into sfc-gh-sjayabalan-sma-regextract-signum-subindex-collectlist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the PR title to
SNOW-802269 Added regexp_extract,signum,substring_index,collect_list
It should start with the Jira number
Modified the pr title.Please verify |
…tlist' of https://github.com/sfc-gh-sjayabalan/snowpark-java-scala into sfc-gh-sjayabalan-sma-regextract-signum-subindex-collectlist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change all versions @since x.xx.x
in this PR to @since 1.15.0
.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Replace this with a short description of how your code change solves the related issue.
Pre-review checklist
(For Snowflake employees)