Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1369263: Fixing documentation on SnowflakeFile. #108

Merged
merged 1 commit into from
May 29, 2024
Merged

SNOW-1369263: Fixing documentation on SnowflakeFile. #108

merged 1 commit into from
May 29, 2024

Conversation

sfc-gh-lschmidt
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1369263

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Update comments

Pre-review checklist

(For Snowflake employees)

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

sfc-gh-bli
sfc-gh-bli approved these changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-bli sfc-gh-bli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-lschmidt sfc-gh-lschmidt enabled auto-merge (squash) May 29, 2024 22:34
@sfc-gh-lschmidt sfc-gh-lschmidt merged commit 9dddb98 into main May 29, 2024
17 checks passed
@sfc-gh-lschmidt sfc-gh-lschmidt deleted the lschmidt-SNOW-docs branch May 29, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-bli sfc-gh-bli sfc-gh-bli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-lschmidt @sfc-gh-bli