Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-802269 Add ordering and size function for scala and java modules #133

Merged
merged 8 commits into from
Aug 7, 2024
Merged

SNOW-802269 Add ordering and size function for scala and java modules #133

merged 8 commits into from
Aug 7, 2024

Conversation

sfc-gh-gmahadevan
Copy link
Collaborator

@sfc-gh-gmahadevan sfc-gh-gmahadevan commented Aug 5, 2024 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

Adding missing ordering and size function available in python module but not in scala and java

Pre-review checklist

(For Snowflake employees)

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@sfc-gh-bli
Copy link
Collaborator

@sfc-gh-gmahadevan
1, do you have jira ticket for this PR? if yes, please add the JIRA number in the PR title, for example, SNOW-XXXXX xxxxx
2, do not push from your forked repo, you can create a branch in this repo and create PRs from this repo, otherwise, the merging gates don't work.

@sfc-gh-gmahadevan sfc-gh-gmahadevan changed the base branch from main to SNOW-802269-func1-gm August 7, 2024 13:50
@sfc-gh-gmahadevan sfc-gh-gmahadevan changed the title Add ordering and size function for scala and java modules SNOW-802269 Add ordering and size function for scala and java modules Aug 7, 2024
@sfc-gh-gmahadevan sfc-gh-gmahadevan merged commit d2339f4 into snowflakedb:SNOW-802269-func1-gm Aug 7, 2024
3 of 15 checks passed
@sfc-gh-gmahadevan sfc-gh-gmahadevan mentioned this pull request Aug 7, 2024
Merged
7 tasks
sfc-gh-gmahadevan added a commit that referenced this pull request Aug 7, 2024
@sfc-gh-gmahadevan @sfc-gh-mrojas
SNOW-802269 Add ordering and size function for scala and java modules… (
d26eb08 
#137)

SNOW-802269 Add ordering and size function for scala and java modules (#133)

* add java and scala size and ordering functions

* add scala unit test for ordering and size function

* update comments and add example

* add java test cases

* fix comments

---------

Co-authored-by: sfc-gh-mrojas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-mrojas sfc-gh-mrojas sfc-gh-mrojas left review comments

@sfc-gh-bli sfc-gh-bli Awaiting requested review from sfc-gh-bli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-gmahadevan @sfc-gh-bli @sfc-gh-mrojas